Change in openvpn[master]: Do not segfault on missing --dh in server config
A message that is not in the archive (sent off-list or not yet received): gerrit.1748876308000.I0e13595c1057c680e1065eae84ca94b273ed9ca1@...2715...
Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1037?usp=email
to review the following change.
Change subject: Do not segfault on missing --dh in server config
......................................................................
Do not segfault on missing --dh in server config
---
M src/openvpn/options.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/37/1037/1
src/openvpn/options.c +1 -1
@@ -3698,7 +3698,7 @@if (o->tls_server) { -if (streq (o->dh_file,"none" )) +if (o->dh_file &&streq (o->dh_file,"none" )) { o->dh_file =NULL ; }
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1037?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I0e13595c1057c680e1065eae84ca94b273ed9ca1
Gerrit-Change-Number: 1037
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>
Gerrit-MessageType: newchange
Attention is currently required from: flichtenheld, plaisthos.
cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1037?usp=email )
Change subject: Do not segfault on missing --dh in server config
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1037?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I0e13595c1057c680e1065eae84ca94b273ed9ca1
Gerrit-Change-Number: 1037
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: cron2 <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>
Gerrit-Attention: flichtenheld <[email protected]...>
Gerrit-Comment-Date: Mon, 02 Jun 2025 15:20:59 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
PATCH 1/1 Do not segfault on missing --dh in server config
In reply to a message not in the archiveFrom: Frank Lichtenheld <[email protected]...>
---
This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master.
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1037
This mail reflects revision 1 of this Change.
Acked-by according to Gerrit (reflected above):
Gert Doering <[email protected]...>
src/openvpn/options.c +1 -1
@@ -3698,7 +3698,7 @@if (o->tls_server) { -if (streq (o->dh_file,"none" )) +if (o->dh_file &&streq (o->dh_file,"none" )) { o->dh_file =NULL ; }
[Openvpn-devel] [PATCH applied] Re: Do not segfault on missing --dh in server config
Apologies.
"The more trivial a patch looks, the more testing it warrants"...
Now *this* patch is rather trivial, and *have* verified that it, indeed, makes a config "with no --dh in it" work with no segfault.
Your patch has been applied to the master branch.
commit 92b9cb5e0363a1c19b76a5a6e5f36c9891406590
Author: Frank Lichtenheld Date: Mon Jun 2 17:21:08 2025 +0200
Do not segfault on missing --dh in server config
Signed-off-by: Frank Lichtenheld <[email protected]...>
Acked-by: Gert Doering <[email protected]...>
Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg31844.html
Signed-off-by: Gert Doering <[email protected]...>--
kind regards,
Gert Doering
cron2 has uploaded a new patch set (#2) to the change originally created by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1037?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by cron2
Change subject: Do not segfault on missing --dh in server config
......................................................................
Do not segfault on missing --dh in server config
Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg31844.html
---
M src/openvpn/options.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/37/1037/2
src/openvpn/options.c +1 -1
@@ -3698,7 +3698,7 @@if (o->tls_server) { -if (streq (o->dh_file,"none" )) +if (o->dh_file &&streq (o->dh_file,"none" )) { o->dh_file =NULL ; }
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1037?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I0e13595c1057c680e1065eae84ca94b273ed9ca1
Gerrit-Change-Number: 1037
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: cron2 <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-MessageType: newpatchset
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/1037?usp=email )
Change subject: Do not segfault on missing --dh in server config
......................................................................
Do not segfault on missing --dh in server config
Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg31844.html
---
M src/openvpn/options.c
1 file changed, 1 insertion(+), 1 deletion(-)
src/openvpn/options.c +1 -1
@@ -3698,7 +3698,7 @@if (o->tls_server) { -if (streq (o->dh_file,"none" )) +if (o->dh_file &&streq (o->dh_file,"none" )) { o->dh_file =NULL ; }
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1037?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I0e13595c1057c680e1065eae84ca94b273ed9ca1
Gerrit-Change-Number: 1037
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: cron2 <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-MessageType: merged